-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] fix(PanelStack2): animation direction in controlled mode #4800
Conversation
Fix PanelStack2 animation direction in controlled modePreviews: documentation | landing | table |
Fix lintPreviews: documentation | landing | table |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix importPreviews: documentation | landing | table |
@adidahiya That crash is actually not caused by this PR. I've found two issues that would cause a crash due to inconsistent number of hooks called:
Either way, given that the issue already exists, let's fix that in a follow-up. |
Filed #4807 for follow-up bug |
Fixes #4686
I have a cherry-pick onto v4's renamed PanelStack ready locally (based on #4799, so not pushing just yet).