[core, popover2] feat: add aria-haspopup attribute #4805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4794
Checklist
Changes proposed in this pull request:
Add
aria-haspopup="true"attribute to the target element rendered by Popover & Popover2 to indicate that it triggers an interactive popup element. I've gone with the generic value of"true"; if users wish to customize this they can use the Popover2 renderTarget prop API.Docs: https://developer.mozilla.org/en-US/docs/Web/API/Element/ariaHasPopup
Reviewers should focus on:
Attribute is being added to the right element... it should be the one which has the popover mouse event handlers, I think.
Screenshot