Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[popover2] fix(ContextMenu2): remove obsolete target CSS #4816

Merged
merged 2 commits into from
Jul 29, 2021
Merged

[popover2] fix(ContextMenu2): remove obsolete target CSS #4816

merged 2 commits into from
Jul 29, 2021

Conversation

invliD
Copy link
Member

@invliD invliD commented Jul 22, 2021

The context-menu class was previously applied to the context menu itself. In ContextMenu2, it's applied to the target. Since it's not using a direct child operator, any descendant popover target inside a context menu target will end up getting display: block.

Given that this was previously not set on the target, and there doesn't appear to ever be a popover-target for the context menu, we may be able to just remove this entirely.

@invliD invliD requested a review from adidahiya July 22, 2021 12:01
adidahiya
adidahiya suggested changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're right, we can remove this display: block style entirely. It's not doing anything useful anymore. I believe it was added to allow the FIXED_POSITIONING_CONTAINING_BLOCK layout to work in 0064ea4, but it was never removed as it should have been in #4740.

@invliD invliD changed the title Use more specific context menu target CSS Remove obsolete context menu target CSS Jul 29, 2021
@blueprint-bot
Copy link

Remove entirely

Previews: documentation | landing | table

@adidahiya adidahiya changed the title Remove obsolete context menu target CSS [popover2] fix: remove obsolete context menu target CSS Jul 29, 2021
@adidahiya adidahiya changed the title [popover2] fix: remove obsolete context menu target CSS [popover2] fix(ContextMenu2): remove obsolete target CSS Jul 29, 2021
@adidahiya adidahiya merged commit 9c93f56 into develop Jul 29, 2021
@adidahiya adidahiya deleted the sb/context-menu2-target branch July 29, 2021 15:29
This was referenced Jan 24, 2022
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adidahiya adidahiya adidahiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@invliD @blueprint-bot @adidahiya