Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[icons] feat: add stadium-geometry + area-of-interest, edit send-message #4824

Merged
merged 11 commits into from
Aug 12, 2021

Conversation

candyyyji
Copy link
Contributor

Fixes #0000

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Added new icon for:

  • area of interest
  • stadium

Edited icon for:

  • send message

Reviewers should focus on:

Everything renders ok and right files were changed

Screenshot

Screen Shot 2021-07-27 at 11 43 31 AM
Screen Shot 2021-07-27 at 11 43 39 AM

@candyyyji candyyyji changed the title Candice/add send message icon add icons Jul 27, 2021
@candyyyji candyyyji changed the title add icons add icons stadium and area of interest Jul 27, 2021
@candyyyji candyyyji changed the title add icons stadium and area of interest [icon] add stadium and area of interest Jul 27, 2021
@candyyyji candyyyji mentioned this pull request Jul 27, 2021
2 tasks
@adidahiya adidahiya changed the title [icon] add stadium and area of interest [icons] feat: add stadium + area-of-interest, edit send-message Jul 28, 2021
@adidahiya
Copy link
Contributor

@candyyyji the send-message icon doesn't look any different? am I missing something?

current live docs:

image

this PR preview:

image

but the new ones look fine:

image

image

btw are we sure this minimal representation of a stadium will be clear enough? IMO it looks like a generic oval, something to do with shapes and drawing rather than a location. have we considered a less minimal representation of a stadium?

@candyyyji
Copy link
Contributor Author

allen asked me to move two vertices by half pixel so the corners snapped to whole pixels... you shouldn't be able to see any difference... 😬

@adidahiya
Copy link
Contributor

cool. I'm still curious about my question from above:

have we considered a less minimal representation of a stadium?

@candyyyji
Copy link
Contributor Author

oh sorry i missed that question!
it's for "holding pattern" in our application https://en.wikipedia.org/wiki/Holding_(aeronautics), but holding pattern isn't generally applicable elsewhere so i found that the mathematical word for this shape, which is "stadium" https://mathworld.wolfram.com/Stadium.html

@candyyyji
Copy link
Contributor Author

we could change the name of this icon though! in case in future we need an actual stadium?

@adidahiya adidahiya changed the title [icons] feat: add stadium + area-of-interest, edit send-message [icons] feat: add stadium-geometry + area-of-interest, edit send-message Aug 12, 2021
@adidahiya
Copy link
Contributor

Discussed offline, renamed to "stadium-geometry"

@adidahiya adidahiya merged commit 1891f16 into palantir:develop Aug 12, 2021
@candyyyji candyyyji deleted the candice/add-send-message-icon branch February 28, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants