Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] fix(Button): icon intent color in dark mode #4834

Merged
merged 1 commit into from
Aug 24, 2021
Merged

[core] fix(Button): icon intent color in dark mode #4834

merged 1 commit into from
Aug 24, 2021

Conversation

tomshen
Copy link
Contributor

@tomshen tomshen commented Aug 3, 2021

Fixes #3696

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

  • Only set default dark icon color if there is no intent on the icon itself

Screenshot

Before:

Screen Shot 2021-08-03 at 4 38 37 PM

After:

Screen Shot 2021-08-03 at 4 36 38 PM

@blueprint-bot
Copy link

Fix button icon intent color in dark mode

Previews: documentation | landing | table

@adidahiya adidahiya changed the title Fix button icon intent color in dark mode [core] fix(Button): icon intent color in dark mode Aug 24, 2021
@adidahiya adidahiya merged commit fc6915d into develop Aug 24, 2021
@adidahiya adidahiya deleted the ts/fix-dark-mode-icon-inside-button branch August 24, 2021 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adidahiya adidahiya adidahiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting button icon intent does not change icon color in dark mode
3 participants
@tomshen @blueprint-bot @adidahiya