-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] feat(Dialog): accessibility aria attributes #4838
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adidahiya
suggested changes
Aug 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's update dialogExample.tsx
as well... I think we just need to add an aria-describedby
prop and point it to an ID we add to the Classes.DIALOG_BODY
element
adidahiya
changed the title
Dialog a11y roles
[core] feat(Dialog): a11y aria attributes
Aug 11, 2021
evansjohnson
changed the title
[core] feat(Dialog): a11y aria attributes
[core] feat(Dialog): accessibility aria attributes
Aug 12, 2021
evansjohnson
force-pushed
the
dialog-a11y-roles
branch
from
August 17, 2021 02:56
808e56c
to
8baad12
Compare
sorry about the test flakes in the table package test suite... I will look into that soon |
adidahiya
suggested changes
Aug 17, 2021
adidahiya
approved these changes
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4528
Checklist
Changes proposed in this pull request:
add
aria-labelledby
andaria-describedby
props toDialog
witharia-labelledby
defaulting totitle
elementScreenshot