[select] feat(Select): new prop "fill" #4843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millasml
changed the title
millasml
changed the title
adidahiya
suggested changes
Aug 12, 2021
| childProps.fill = true; | ||
| } | ||
|
|
||
| const children = React.Children.map(this.props.children, (child: React.ReactNode) => { |
There was a problem hiding this comment.
I don't love this approach and would prefer not to clone children if we can avoid it. We can't guarantee that the children will support the fill prop, and I'd rather not send along extraneous HTML attributes which might get rendered out to the DOM (and produce a React warning).
If we stick to just rendering {this.props.children}, then <Select> users will have to add fill to children themselves (or style it some other way), but I think that's ok. We should make a note of that in the fill prop documentation.
|
the docs example doesn't work anymore, it needs to be updated so that the button uses
|
adidahiya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4721
Checklist
Changes proposed in this pull request:
Fill prop that makes the select component fill component width.
Screenshot