[icons] feat: new icons "antenna", "tank" #4851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmalangfitt
force-pushed
the
el/antenna-tank-icons
branch
from
0310c23
to
85c122b
Compare
emmalangfitt
force-pushed
the
el/antenna-tank-icons
branch
from
85c122b
to
3a29a63
Compare
aycai
reviewed
Aug 11, 2021
aycai
reviewed
Aug 11, 2021
|
Designs look good! Left a few nits |
adidahiya
reviewed
Aug 13, 2021
adidahiya
changed the title
|
@aycai top of the 16px tank and the bottom of the 20px tank look a little blurry, but this is fine for a first version of the icon |
|
antenna looks great! |
@adidahiya Strange, the vector edges line up to the pixel when I check the svg in app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add antenna and tank icons
Checklist
Changes proposed in this pull request:
Add 16px and 20px antenna and tank icons
Reviewers should focus on:
Correct files changed, icons render correctly
Screenshot