[stylelint-plugin] feat: add no-color-literal rule #4853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-bp3-selector.scss
adidahiya
approved these changes
Aug 11, 2021
| @@ -0,0 +1,49 @@ | |||
| /* Copyright 2020 Palantir Technologies, Inc. All rights reserved. | |||
There was a problem hiding this comment.
minor nit: these copyright headers don't have the right comment syntax. I can fix in a follow-up.
adidahiya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new stylelint rule that encourages using color variables (
$blue3and etc) instead of color literals (#137CBDand etc).