Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[table] fix issues with blank rows/columns on mount/resize #4884

Merged
merged 2 commits into from
Aug 30, 2021

Conversation

adidahiya
Copy link
Contributor

@adidahiya adidahiya commented Aug 30, 2021

fixes #3779, #3941

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

  • Update the "basic usage" table example to repro the bug described in Blank table when resizing columns #3941
  • Adjust some viewport rect code to be more defensive about and provide defaults (top = 0, left = 0) for when the scroll container element ref is null, or doesn't have client coordinates. This fixes the edge cases where the visible grid would be incorrectly calculated as the top left 4x4 cells, and only those cells would render

Reviewers should focus on:

N/A

Screenshot

2021-08-30 17 24 14

@adidahiya adidahiya changed the title update basic usage example to demonstrate bug [table] fix issues with blank rows/columns on mount/resize Aug 30, 2021
@adidahiya
Copy link
Contributor Author

This is a relatively safe change and it passes the test suite, so I'm going to push it through to verify that it fixes the related bugs in practice.

@adidahiya adidahiya merged commit 5e42a0d into develop Aug 30, 2021
@adidahiya adidahiya deleted the ad/table-resize-bug branch August 30, 2021 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Table] only 4 columns render on table mounted if table horizontal overflow
2 participants