[core] fix(MenuItem): make items focusable for a11y consistency #4892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adidahiya
changed the title
[core] fix(MenuItem): add tabIndex={0} to make items focussablePreviews: documentation | landing | table |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4810
Changes proposed in this pull request:
Apply
tabIndex="0"to all MenuItems by default, even if they don't have anhreforonChange. The reasoning for this is that we make MenuItems look interactive regardless of whether they are actually hooked up to do something in an application (with:hoverand:activestyles), so for accessible consistency we should also make them focusable via the keyboard.Reviewers should focus on:
N/A
Screenshot
Before this PR (pressing TAB, TAB, TAB, TAB, SHIFT+TAB, SHIFT+TAB, SHIFT+TAB, SHIFT+TAB):
After this PR (pressing TAB, TAB, TAB, TAB, SHIFT+TAB, SHIFT+TAB, SHIFT+TAB, SHIFT+TAB):