[popover2] feat(Popover2): allow enter key to open popover #4898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update docsPreviews: documentation | landing | table |
prettierPreviews: documentation | landing | table |
adidahiya
suggested changes
Sep 13, 2021
adidahiya
changed the title
adidahiya
approved these changes
Sep 14, 2021
address PR feedbackPreviews: documentation | landing | table |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Changes proposed in this pull request:
Currently if the target is focused and the popover is meant to open on click, then you cannot open the popover via keyboard-only navigation.
This change makes it at least so that pressing enter while the target is focused the popover will open. Note that the popover currently always steals focus away from the target, so that you cannot press enter again in the same way that you could click the target again to close the popover. I'm not sure what was intended behavior (stealing focus) or not, so I could use advice as to how would we allow focus to remain on the target such that 2 enter key presses opens and then closes the popover
Reviewers should focus on:
Any other gotchas with adding this event listener?
Screenshot