-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[colors] feat: add modern colors in preparation for v5.x #4906
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's add a legacyColors.ts
file with the old colors...
// legacyColors.ts
export const LegacyColors = {
// ...
};
and then core should re-export these colors to avoid a breaking change:
// core/src/common/index.ts
import { LegacyColors } from "@blueprintjs/colors";
export Colors = LegacyColors;
consumers who wish to use the new colors can just switch to the new package:
import { Colors } from "@blueprintjs/colors";
not sure why the CI workflow wasn't getting triggered before... but after pushing my commit merging develop it looks like it's running |
Merge remote-tracking branch 'origin/develop' into johnlee/modern-colorsPreviews: documentation | landing | table |
dist:variables in colors packagePreviews: documentation | landing | table |
I added Cascading variable declarationsWe are moving to an API where consumers wishing to use the new colors in 3.x (and the eventual stable API in 5.0) are recommended to import multiple Sass files if they use both colors and other BP variables (like grid size): @import "~@blueprintjs/colors/lib/scss/colors";
@import "~@blueprintjs/core/lib/scss/variables"; The problem with this is that I recommend changing Color variables file nameThe packages/colors I recommend changing |
the behavior of the stylelint rule to avoid color literals has changed now. I think we should make it use |
Merge remote-tracking branch 'origin' into johnlee/modern-colorsPreviews: documentation | landing | table |
Use LegacyColors instead of Colors in no-color-literal styelint rulePreviews: documentation | landing | table |
Upgraded However, I noticed the |
@ptgamr use popover2 v1.0.0-beta.x, the new colors are there |
Checklist
Changes proposed in this pull request:
@blueprintjs/colors@5.x
is published, I'll make follow-up PRs to:@blueprintjs/colors
dependency and creating a newblueprint-modern-colors.scss
, which contains the line@import "@blueprintjs/colors/lib/css/colors.css
@blueprintjs/core
that has the line@import "@blueprintjs/colors/lib/css/colors.css
, along with the rest of the blueprint variables (will require an update togenerate-css-variables.js
to accept an output file name)packages/colors/src/colors.scss
Reviewers should focus on:
Screenshot