[core] fix(Overlay): capture focus when it returns to document #4907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-yx-wu
commented
Sep 14, 2021
| const decoratedChild = | ||
| typeof child === "object" ? ( | ||
| React.cloneElement(child as React.ReactElement, { | ||
| className: classNames((child as React.ReactElement).props.className, Classes.OVERLAY_CONTENT), | ||
| tabIndex: this.props.enforceFocus || this.props.autoFocus ? 0 : undefined, |
There was a problem hiding this comment.
removing this fixes an issue w/ the omnibar where the container and the input are both focusable, even though you probably don't want the container to be focusable in that situation. now that we have focus traps, this doesn't seem necessary. if consumers want non-focusable elements to be focusable, they will need to take care to set tabindex themselves. not sure if this constitutes a break
michael-yx-wu
force-pushed
the
mw/dialog-enforceFocus-from-browser
branch
from
b770f77
to
2bc9d82
Compare
Capture focus when it returns to the documentPreviews: documentation | landing | table |
adidahiya
suggested changes
Sep 15, 2021
…ocus-from-browser
|
I think this is a result of the infinite focus bug due to |
Comment grammarPreviews: documentation | landing | table |
adidahiya
approved these changes
Sep 20, 2021
adidahiya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #4894 (comment)
Screenshot
Before -- focus would not return to overlay if coming back to the document from somewhere outside (e.g. url, native browser controls)
After -- focus immediately returns to overlay