Upgrade to TS 2.1 #492

giladgray · 2017-01-16T18:27:30Z

Fixes #376, Fixes #11

Checklist

tslib
Partial for props in some test suites
extends outside of gulp-typescript 😭 Support for configuration inheritance ivogabe/gulp-typescript#459

Changes proposed in this pull request:

update typescript and gulp-typescript
replace Object.assign and Utils.shallowClone with object spreads
some lint fixes in table examples
⚠️ new dependency on tslib for --importHelpers flag
- this reduces the size of each source file at the cost of one additional NPM dependency
use Partial<Props> in test suites for components that have required props!
use extends in tsconfig.json files that are never built with gulp-typescript

also fix some linting issues

though it still doesn't support `extends` 😭 ivogabe/gulp-typescript#459

adidahiya

the "extends" thing is really unfortunate... I've started using it in other projects and am a big fan

adidahiya · 2017-01-16T18:39:56Z

packages/core/src/common/utils.ts

@@ -50,17 +50,6 @@ export function clamp(val: number, min: number, max: number) {
    return Math.min(Math.max(val, min), max);
 }

-/** Return a new object with the same keys as the given object (values are copied, not cloned). */
-export function shallowClone<T>(object: T): T {


adidahiya · 2017-01-16T18:40:55Z

packages/table/preview/index.tsx

@@ -40,51 +40,52 @@ import {
    Utils,
 } from "../src/index";

+// tslint:disable:max-classes-per-file no-console jsx-no-lambda jsx-no-multiline-js


do we need to disable jsx-no-multiline-js? would prefer to keep it

same but would prefer not to touch this file too much. most of what you see here was done automatically by TSLint or VSCode formatting.

adidahiya · 2017-01-16T18:41:50Z

packages/table/preview/index.tsx

+            isColumnResizable: false,
+            isRowResizable: false,
+            selectionModes: SelectionModes.NONE,
+        }),


this indentation change looks wrong, the previous alignment is preferred

sure, i didn't look closely at the formatting. maybe i'll just revert, it's not super relevant.

adidahiya · 2017-01-16T18:42:04Z

packages/table/preview/index.tsx

+                    ],
+                },
+            ],
+        }),


adidahiya · 2017-01-16T18:43:04Z

what do you plan to do with tslib and Partial?

giladgray · 2017-01-16T18:47:02Z

avail myself of them :) marking this WIP for now.

hence the unchecked tasks.

giladgray · 2017-01-16T18:48:52Z

FWIW, i'm able to use extends in a few places, like test tsconfigs, which are only ran via webpack. might be able to do examples too for the same reason.

so it really only affects packages/*/tsconfig.json, the ones that get run through gulp-typescript.

- add `tslib` dependency - test tsconfigs can safely extend package root tsconfigs because tests are only run from webpack (never gulp-typescript)

giladgray · 2017-01-17T15:19:12Z

@themadcreator @gscshoyru Table code coverage is failing the build. seems like a test for column resizing would fix it swimmingly. might one of you be able to take that one this week?

https://1214-71939872-gh.circle-artifacts.com/0/home/ubuntu/blueprint/packages/table/coverage/PhantomJS%202.1.1%20(Linux%200.0.0)/src/table.tsx.html

ideal for components that have required props!

adidahiya · 2017-01-17T18:36:10Z

@giladgray why would coverage change as a result of this PR? Those things should really be decoupled; please don't add a test in this PR.

giladgray · 2017-01-17T22:54:15Z

i'm not planning to add a test in this PR and I'm not sure exactly why coverage changed. you'll notice it's extremely close to the threshold (79%, must be 80% to pass) so all it would have taken is one little tweak to drop coverage below the threshold. my guess is that switching to tslib removed enough code from the file as to reveal this.

blueprint-bot · 2017-01-18T13:57:49Z

reduce code coverage limit by 1% to fix build

Preview: docs | landing | table
Coverage: core | datetime

giladgray · 2017-01-23T11:21:59Z

ready 4 review 👀

adidahiya

overall, looks good, but:

this reduces the size of each source file at the cost of one additional NPM dependency

sorry, performance enhancements shouldn't be merged without measurements. what is the impact of this for the end user? are they actually saving on bundle size?

adidahiya · 2017-01-24T17:34:50Z

nvm, I read the 2.1 release notes, this looks legit

Gilad Gray added 4 commits January 16, 2017 17:41

upgrade package.json to typescript@2.1.5

4608809

refactor Object.assign usages in table

cd32723

also fix some linting issues

replace Utils.shallowClone with object spread

9732d15

update gulp-typescript

e381415

though it still doesn't support `extends` 😭 ivogabe/gulp-typescript#459

giladgray added the Type: refactor label Jan 16, 2017

adidahiya reviewed Jan 16, 2017

View reviewed changes

giladgray added the Status: work in progress label Jan 16, 2017

Gilad Gray added 2 commits January 16, 2017 18:54

set new --importHelpers flag

5feaafa

- add `tslib` dependency - test tsconfigs can safely extend package root tsconfigs because tests are only run from webpack (never gulp-typescript)

fix test compiler errors due to tsconfig extends

c88415d

leebyp mentioned this pull request Jan 16, 2017

Migrate es6-shim whatwg-fetch react-day-picker typings #475

Merged

Gilad Gray added 2 commits January 17, 2017 15:03

revert formatting of table preview

af3c1a6

capture table coverage reports in circle.yml

3005f7d

giladgray assigned themadcreator and gscshoyru Jan 17, 2017

use Partial<Props> in some test suites

da423a0

ideal for components that have required props!

reduce code coverage limit by 1% to fix build

656e203

giladgray unassigned themadcreator and gscshoyru Jan 18, 2017

giladgray mentioned this pull request Jan 18, 2017

Consistent TS compiler flags in table #510

Merged

giladgray removed the Status: work in progress label Jan 23, 2017

adidahiya self-assigned this Jan 23, 2017

adidahiya suggested changes Jan 24, 2017

View reviewed changes

adidahiya approved these changes Jan 24, 2017

View reviewed changes

adidahiya merged commit 53a0721 into master Jan 24, 2017

adidahiya deleted the gg/ts21 branch January 24, 2017 17:36

giladgray mentioned this pull request Jan 27, 2017

Prepare Release 1.7.0 #563

Merged

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to TS 2.1 #492

Upgrade to TS 2.1 #492

giladgray commented Jan 16, 2017 •

edited

Loading

adidahiya left a comment

adidahiya Jan 16, 2017

adidahiya Jan 16, 2017

giladgray Jan 16, 2017 •

edited

Loading

adidahiya Jan 16, 2017

giladgray Jan 16, 2017

adidahiya Jan 16, 2017

adidahiya commented Jan 16, 2017

giladgray commented Jan 16, 2017 •

edited

Loading

giladgray commented Jan 16, 2017

giladgray commented Jan 17, 2017

adidahiya commented Jan 17, 2017

giladgray commented Jan 17, 2017 •

edited

Loading

blueprint-bot commented Jan 18, 2017

giladgray commented Jan 23, 2017

adidahiya left a comment

adidahiya commented Jan 24, 2017

Upgrade to TS 2.1 #492

Upgrade to TS 2.1 #492

Conversation

giladgray commented Jan 16, 2017 • edited Loading

Fixes #376, Fixes #11

Checklist

Changes proposed in this pull request:

adidahiya left a comment

Choose a reason for hiding this comment

adidahiya Jan 16, 2017

Choose a reason for hiding this comment

adidahiya Jan 16, 2017

Choose a reason for hiding this comment

giladgray Jan 16, 2017 • edited Loading

Choose a reason for hiding this comment

adidahiya Jan 16, 2017

Choose a reason for hiding this comment

giladgray Jan 16, 2017

Choose a reason for hiding this comment

adidahiya Jan 16, 2017

Choose a reason for hiding this comment

adidahiya commented Jan 16, 2017

giladgray commented Jan 16, 2017 • edited Loading

giladgray commented Jan 16, 2017

giladgray commented Jan 17, 2017

adidahiya commented Jan 17, 2017

giladgray commented Jan 17, 2017 • edited Loading

blueprint-bot commented Jan 18, 2017

reduce code coverage limit by 1% to fix build

giladgray commented Jan 23, 2017

adidahiya left a comment

Choose a reason for hiding this comment

adidahiya commented Jan 24, 2017

giladgray commented Jan 16, 2017 •

edited

Loading

giladgray Jan 16, 2017 •

edited

Loading

giladgray commented Jan 16, 2017 •

edited

Loading

giladgray commented Jan 17, 2017 •

edited

Loading