[core] feat(EditableText): new HTML prop "contentId" #4935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[core] Allow passing an ID attribute to underlying text content in EditableTextPreviews: documentation | landing | table | modern colors demo |
adidahiya
suggested changes
Sep 28, 2021
rename to contentIdPreviews: documentation | landing | table | modern colors demo |
adidahiya
approved these changes
Sep 28, 2021
adidahiya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Changes proposed in this pull request:
I would like to associate the underlying text in
EditableTextto different content outside theEditableTextviaaria-labeledby. Doing so requires that the span that contains the text has anidattribute that can be passed in, so this PR plumbs such a prop through. Open to better naming suggestions though.