Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v4] [core] fix(MenuItem): inherit menu item content colors #4944

Merged
merged 1 commit into from
Oct 1, 2021
Merged

[v4] [core] fix(MenuItem): inherit menu item content colors #4944

merged 1 commit into from
Oct 1, 2021

Conversation

johnly13
Copy link
Contributor

Fixes #0000

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

  • Fixes colors turning to white on menu items on hover/active for ::before and ::after elements

Reviewers should focus on:

Screenshot

@blueprint-bot
Copy link

Inherit menu item content colors

Previews: documentation | landing | table | modern colors demo

@adidahiya adidahiya changed the title Inherit menu item content colors [v4] [core] fix(MenuItem): inherit menu item content colors Oct 1, 2021
@adidahiya adidahiya merged commit 1e3965e into next Oct 1, 2021
@adidahiya adidahiya deleted the johnlee/fix-menu-icon-intent branch October 1, 2021 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adidahiya adidahiya adidahiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnly13 @blueprint-bot @adidahiya