Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4] [icons] fix: icon paths are right-side up #4984

Merged
merged 3 commits into from
Oct 25, 2021

Conversation

adidahiya
Copy link
Contributor

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

  • Revert to the old method of generating the icon path strings using the svgo package
    • Before this change, we were parsing the output SVG font output of fantasticon, which for some reason was rendering all paths upside-down.
    • Now, we no longer need the CSS transform to flip the svg in the icon component, and consumers who reference IconSvgPaths16 / IconSvgPaths20 don't have to add that unnecessary transform either
  • The type of IconSvgPaths16 / IconSvgPaths20 has been reverted to its type in v3.x, so we no longer have that API break as part of the 4.0 changes

Reviewers should focus on:

Icons page renders correctly

Screenshot

image

@blueprint-bot
Copy link

remove extraneous code comment

Previews: documentation | landing | table | modern colors demo

@adidahiya adidahiya merged commit a5c4ada into next Oct 25, 2021
@adidahiya adidahiya deleted the ad/fix-icons-upside-down branch October 25, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants