Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4] [core] fix(InputGroup): no border on disabled inputs #4987

Merged
merged 2 commits into from
Oct 27, 2021

Conversation

adidahiya
Copy link
Contributor

@adidahiya adidahiya commented Oct 26, 2021

Fixes #4986, fixes #4988

Changes proposed in this pull request:

Fix selector for disabled text inputs in "modern colors" Sass code

Reviewers should focus on:

No regressions

Screenshot

image

@blueprint-bot
Copy link

[v4] [core] fix(InputGroup): no border on disabled inputs

Previews: documentation | landing | table | modern colors demo

@adidahiya
Copy link
Contributor Author

Fixed the lingering concerns in #4988 as well

@blueprint-bot
Copy link

fix placeholder disabled text color

Previews: documentation | landing | table | modern colors demo

@adidahiya adidahiya merged commit a5bee7b into next Oct 27, 2021
@adidahiya adidahiya deleted the ad/v4-fix-disabled-input-border branch October 27, 2021 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants