Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4] [core] fix(MenuItem): improve interactive styles #4990

Merged
merged 3 commits into from
Oct 27, 2021

Conversation

adidahiya
Copy link
Contributor

Fixes #4985

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

  • Update MenuItem colors to match the intended v4 designs
  • Move MenuItem "modern colors" style overrides into the default style code in components/menu/

Reviewers should focus on:

  • All the different states & props for MenuItem (see new example)
  • Select dropdown interactions
  • MultiSelect dropdown interactions

Screenshot

2021-10-27 01 32 37

@blueprint-bot
Copy link

[v4] [core] fix(MenuItem): improve interactive styles

Previews: documentation | landing | table | modern colors demo

@aycai
Copy link
Contributor

aycai commented Oct 27, 2021

I think this makes the most sense in the select context where the MenuItem changes to blue when selected. That said, selected states should include something else like an icon regardless, so this works on its own.

@aycai
Copy link
Contributor

aycai commented Oct 27, 2021

Caught a visual nit - text of root MenuItem changes to default text
Screen Shot 2021-10-27 at 1 26 32 PM
:
Screen Shot 2021-10-27 at 1 25 13 PM

@adidahiya
Copy link
Contributor Author

Fixed styles when submenus are open:
2021-10-27 15 11 20

@blueprint-bot
Copy link

fix submenu styles, add classes to target icons better

Previews: documentation | landing | table | modern colors demo

@adidahiya
Copy link
Contributor Author

slight regression in custom icon placement:

image

@blueprint-bot
Copy link

Fix icon placement

Previews: documentation | landing | table | modern colors demo

@adidahiya adidahiya merged commit 315c5cd into next Oct 27, 2021
@adidahiya adidahiya deleted the ad/v4-fix-menu-item-colors branch October 27, 2021 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants