Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4] [icons] fix: remove dependency on type-fest #5010

Merged
merged 3 commits into from
Nov 4, 2021

Conversation

adidahiya
Copy link
Contributor

Changes proposed in this pull request:

Remove dependency on "type-fest" package since it causes some surprising TS errors downstream:

[error] TypeScript error node_modules/.pnpm/type-fest@1.4.0/node_modules/type-fest/ts41/get.d.ts:68:45 - error TS2344: Type 'string | number' does not satisfy the constraint 'string'.
  Type 'number' is not assignable to type 'string'.

68 type WithStringKeys<BaseType extends Record<string | number, any>> = {
                                               ~~~~~~~~~~~~~~~

In its place, I've copy-pasted the code into the icons package. type-fest's README says this is ok to do, no attribution needed.

@blueprint-bot
Copy link

fix file ext

Previews: documentation | landing | table | modern colors demo

@blueprint-bot
Copy link

fix lint

Previews: documentation | landing | table | modern colors demo

@adidahiya adidahiya merged commit 69b182a into next Nov 4, 2021
@adidahiya adidahiya deleted the ad/v4-remove-type-fest branch November 4, 2021 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants