Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4] [core] chore: fix isolatedModules compilation error #5015

Merged
merged 2 commits into from
Nov 8, 2021

Conversation

LevanKvirkvelia
Copy link
Contributor

@LevanKvirkvelia LevanKvirkvelia commented Nov 7, 2021

Simple build error fix, when isolatedModules flag is provided.

Re-exporting a type when the '--isolatedModules' flag is provided requires using 'export type'.  TS1205

    22 | import { AbstractPureComponent2, Classes, DISPLAYNAME_PREFIX, IntentProps, Props, MaybeElement } from "../../common";
    23 | 
  > 24 | export { IconName };
       |          ^
    25 | 
    26 | export enum IconSize {
    27 |     STANDARD = 16,

Re-exporting a type when the '--isolatedModules' flag is provided requires using 'export type'.  TS1205

    22 | import { AbstractPureComponent2, Classes, DISPLAYNAME_PREFIX, IntentProps, Props, MaybeElement } from "../../common";
    23 | 
  > 24 | export { IconName };
       |          ^
    25 | 
    26 | export enum IconSize {
    27 |     STANDARD = 16,
Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks @inkout

@adidahiya adidahiya changed the title Fix isolatedModules error with "Icon" component [v4] [icons] chore: fix isolatedModules compilation error Nov 8, 2021
@adidahiya adidahiya merged commit 2c6c046 into palantir:next Nov 8, 2021
@adidahiya adidahiya changed the title [v4] [icons] chore: fix isolatedModules compilation error [v4] [core] chore: fix isolatedModules compilation error Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants