[v4] [core] fix(AnchorButton): warning button colors #5021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix lintPreviews: documentation | landing | table | modern colors demo |
|
lgtm! |
|
just noticed outlined warning buttons have the wrong background. will need to add more special case CSS for tthis:
|
|
all the different variants of warning buttons should be styled properly now: |
more styling tweaksPreviews: documentation | landing | table | modern colors demo |
adidahiya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5017
Checklist
Changes proposed in this pull request:
Update styling for "warning" intent disabled buttons to match the intended designs
Before:
After:
Reviewers should focus on:
No regressions in other buttons
Screenshot
See above