Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4] [core] fix(MenuItem): remove left margin when no icon #5023

Merged
merged 1 commit into from
Nov 11, 2021

Conversation

adidahiya
Copy link
Contributor

@adidahiya adidahiya commented Nov 11, 2021

Fixes #5012

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Stop rendering the .bp4-menu-item-icon element with a margin style when there is no icon passed to <MenuItem>

Reviewers should focus on:

N/A

Screenshot

Before:

image
image

After:

image

@blueprint-bot
Copy link

[v4] [core] fix(MenuItem): remove left margin when no icon is displayed

Previews: documentation | landing | table | modern colors demo

@adidahiya adidahiya changed the title [v4] [core] fix(MenuItem): remove left margin when no icon is displayed [v4] [core] fix(MenuItem): remove left margin when no icon Nov 11, 2021
@adidahiya adidahiya merged commit 71e94fa into next Nov 11, 2021
@adidahiya adidahiya deleted the ad/v4-fix-menu-item-icon-layout branch November 11, 2021 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants