[v4] [core] feat: update checkbox and radio colors #5056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnly13
commented
Dec 2, 2021
| @@ -28,14 +28,6 @@ $dark-minimal-button-intents-modern: ( | |||
| "warning": (rgba($orange3, 0.2), $orange5, rgba($orange3, 0.3), $orange6), | |||
| "danger": (rgba($red3, 0.2), $red5, rgba($red3, 0.3), $red6) | |||
| ); | |||
| $minimal-button-background-color-hover: rgba($gray3, 0.15); | |||
There was a problem hiding this comment.
made these overrides the defaults
johnly13
commented
Dec 2, 2021
| @@ -237,37 +229,7 @@ $tree-intent-icon-colors-modern: ( | |||
| } | |||
| } | |||
|
|
|||
| // Contrast for checkboxes and radio buttons | |||
| .#{$ns}-control { | |||
There was a problem hiding this comment.
removed most of these except for
input:focus ~ .#{$ns}-control-indicator {
outline: $blue5 auto 2px;
}
[v4] [core] feat: update checkbox and radio colorsPreviews: documentation | landing | table | modern colors demo |
adidahiya
approved these changes
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Checkboxes and radio buttons currently follow default button styling. However, in dark mode, the need to have a darker border means the fill has to be light, making it stand out as a light box in context.
The visual change not only converts the dark mode unselected states to an outline, but changes the style overall. Unselected states now follow minimal button backgrounds when unselected, and dark mode selected states using a lighter border to match.
Reviewers should focus on:
No regressions, and styles match mocks
Screenshot
Checkbox
Radio