[v4] [core] fix(InputGroup): no overlapping box shadows #5069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[v4] [core] fix(InputGroup): no overlapping box shadowsPreviews: documentation | landing | table | modern colors demo |
Fix lintPreviews: documentation | landing | table | modern colors demo |
adidahiya
approved these changes
Dec 14, 2021
adidahiya
suggested changes
Dec 14, 2021
| inset 0 -1px 0 rgba($black, 0.2), | ||
| inset 1px 0 0 rgba($black, 0.2) !default; | ||
| $pt-input-box-shadow: inset 0 0 0 1px rgba(17, 20, 24, 0.2), | ||
| inset 0 1px 1px rgba(17, 20, 24, 0.5) !default; |
There was a problem hiding this comment.
actually these should stay as $black references
There was a problem hiding this comment.
ooh good catch - pushing up the fix now
Use ref instead of hexcodePreviews: documentation | landing | table | modern colors demo |
adidahiya
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #0000
Checklist
Changes proposed in this pull request:
Reviewers should focus on:
Screenshot