Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[icons] fix: replace require import with esm import #5108

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

jonluca
Copy link
Contributor

@jonluca jonluca commented Jan 24, 2022

Fixes #5054

Changes proposed in this pull request:

Revert the imports to use esm, so that it does not fail in vite

Reviewers should focus on:

n/a

@palantirtech
Copy link
Member

Thanks for your interest in palantir/blueprint, @jonluca! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@jonluca jonluca changed the title change import to esm fix(icons): change import to esm Jan 24, 2022
@jonluca
Copy link
Contributor Author

jonluca commented Jan 28, 2022

@adidahiya let me know if this looks good, would fix blueprint 4 with Vite for me. Thanks!

Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the PR! sorry for the delayed review.

@adidahiya adidahiya changed the title fix(icons): change import to esm [icons] fix: replace require import with esm import Feb 10, 2022
@adidahiya adidahiya merged commit 6ea7e37 into palantir:next Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants