Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add popper modifier classnames #5109

Merged
merged 1 commit into from
Jan 28, 2022

Conversation

justinbhopper
Copy link
Contributor

Changes proposed in this pull request:

This adds new classes to the popover using some of the helpful modifiers from PopperJS's hide.

These classnames can be helpful to allow consumers to hide the popper when the reference element is scrolled out of its scrolling container.
See example: https://popper.js.org/docs/v2/modifiers/hide/

For Popover (@blueprintjs/core):

  • Adds .bp3-popover-out-of-boundaries when PopperJS v1's popperProps.outOfBoundaries is true

For Popover2 (@blueprintjs/popover2):

  • Adds .bp3-popover-reference-hidden when the reference element is not visible (scrolled off screen)
  • Adds .bp3-popper-escaped when the popper escapes the reference element's boundaries

This PR does not change any behavior other than rendering the new classnames, which have no styles applied to them by default.

Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice and simple, good PR description 👍

@adidahiya adidahiya changed the title Add popper modifier classnames feat: Add popper modifier classnames Jan 28, 2022
@adidahiya adidahiya merged commit 57b53e5 into palantir:develop Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants