[v4] [core] fix(AnchorButton): disabled minimal color styling #5137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adidahiya
changed the title
|
Sweet! When do you expect a version with this change to be published? |
|
I'll probably cut the next release tomorrow or early next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5136
Checklist
Changes proposed in this pull request:
the
:disabledselector doesn't work for AnchorButtons or MenuItems, since the:disabledselector isn't valid foratags.This PR adds
.#{$ns)-disabledto every instance of:disabledto ensure that styling is applied to disabled AnchorButtons + MenuItems as well.Reviewers should focus on:
AFAIK this isn't unit testable since it's a failure in how the CSS is getting applied. Are there any selenium-ish tests for
core?Screenshot
Before:
After:
Circle Preview
Or from local dev: