Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4] [core] fix(AnchorButton): disabled minimal color styling #5137

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

zachkirsch
Copy link
Contributor

@zachkirsch zachkirsch commented Feb 22, 2022

Fixes #5136

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

the :disabled selector doesn't work for AnchorButtons or MenuItems, since the :disabled selector isn't valid for a tags.

This PR adds .#{$ns)-disabled to every instance of :disabled to ensure that styling is applied to disabled AnchorButtons + MenuItems as well.

Reviewers should focus on:

AFAIK this isn't unit testable since it's a failure in how the CSS is getting applied. Are there any selenium-ish tests for core?

Screenshot

Before:

Screen Shot 2022-02-21 at 5 13 16 PM

After:

Circle Preview

Or from local dev:

Screen Shot 2022-02-21 at 6 49 06 PM

@adidahiya adidahiya changed the title Always use disabled class selector in css [v4] [core] fix(AnchorButton): disabled minimal color styling Feb 24, 2022
Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, thanks!

@adidahiya adidahiya merged commit af87e29 into palantir:next Feb 24, 2022
@zachkirsch
Copy link
Contributor Author

Sweet! When do you expect a version with this change to be published?

@adidahiya
Copy link
Contributor

I'll probably cut the next release tomorrow or early next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants