Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] feat: make component props readonly #5148

Merged
merged 1 commit into from
Mar 1, 2022
Merged

[core] feat: make component props readonly #5148

merged 1 commit into from
Mar 1, 2022

Conversation

drewthoennes
Copy link
Contributor

No ticket

Changes proposed in this pull request:

This PR makes various component props readonly. These components don't mutate these array props, and doing this allows consumers to directly pass readonly arrays instead of casting or avoiding readonly altogether.

@palantirtech
Copy link
Member

Thanks for your interest in palantir/blueprint, @drewthoennes! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@adidahiya adidahiya self-requested a review February 28, 2022 18:32
@adidahiya adidahiya changed the title Make core component props readonly [core] feat: make component props readonly Mar 1, 2022
@adidahiya adidahiya merged commit fc9ffd7 into palantir:develop Mar 1, 2022
@zachkirsch
Copy link
Contributor

epic @drewthoennes 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants