Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v4] [table] fix lifecycle bugs scrolling + resizing #5151

Merged
merged 2 commits into from
Mar 1, 2022
Merged

[v4] [table] fix lifecycle bugs scrolling + resizing #5151

merged 2 commits into from
Mar 1, 2022

Conversation

adidahiya
Copy link
Contributor

Changes proposed in this pull request:

  • Fix children diffing code to accurately determine when Table2's children change (previously, this would be triggered too often)
  • Remove buggy calls in componentDidUpdate which turned out to be unnecessary to sync viewport / quadrant stack position. These were causing a bug where rows were rendered blank after resizing columns when the table body was scrolled down any amount.

Reviewers should focus on:

No regressions

Screenshot

@blueprint-bot
Copy link

clean up a bit

Previews: documentation | landing | table | modern colors demo

@adidahiya adidahiya merged commit b2b5496 into next Mar 1, 2022
@adidahiya adidahiya deleted the ad/v4-fix-table-scrolling branch March 1, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adidahiya @blueprint-bot