[core] fix(OverflowList): improve spacer width check #5168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your interest in palantir/blueprint, @dylanrcooke! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
invliD
approved these changes
Mar 15, 2022
There was a problem hiding this comment.
@adidahiya to confirm that this minor break is ok. We'll also need this on 4.x.
| @@ -151,7 +151,7 @@ export class OverflowList<T> extends React.Component<OverflowListProps<T>, IOver | |||
| /** A cache containing the widths of all elements being observed to detect growing/shrinking */ | |||
| private previousWidths = new Map<Element, number>(); | |||
|
|
|||
| private spacer: Element | null = null; | |||
| private spacer: HTMLElement | null = null; | |||
There was a problem hiding this comment.
Technically this no longer allows non-HTML usage of the overflow list, but given that it's relatively specific for HTML layout, I'm ok with this.
| } else if (this.spacer.getBoundingClientRect().width < 0.9) { | ||
| } else if (this.spacer.offsetWidth < 0.9) { |
There was a problem hiding this comment.
I tested this works in our internal repro.
adidahiya
approved these changes
Mar 16, 2022
adidahiya
changed the title
adidahiya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5167
Checklist
Changes proposed in this pull request:
Fix the OverflowList spacer width check to account for css scaling
Reviewers should focus on:
Any risks to using
offsetWidthinstead ofgetBoundingClientRect()Screenshot
No user facing change