[datetime] fix: clicking shortcuts no longer dismisses popovers #5219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 1, 2022 14:37
lintPreviews: documentation | landing | table | demo |
|
before: after: |
adidahiya
approved these changes
Apr 1, 2022
adidahiya
changed the title
not-inept
added a commit
that referenced
this pull request
Apr 1, 2022
Co-authored-by: Mason Cooper <mcooper@palantir.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3338
By default MenuItem has
Classes.POPOVER_DISMISSadded to the component, controlled by theshouldDismissPopoverprop.The
Shortcutscomponent clearly intended to block this behavior through the use ofClasses.POPOVER_DISMISS_OVERRIDE.However, per the
PopoverandPopover2components, a dismiss inside an override still dismisses.Luckily,
MenuItemhas a prop just for this!Changes proposed in this pull request:
Stop datepicker shortcuts from dismissing popovers
Reviewers should focus on:
If this correctly dismisses popovers and aligns with the author's original intent.
Screenshot
(Imagine a picture of a happy dev, not having to insert some hack to strip the dismiss class from the child menuitem)