[node-build-scripts] fix Less variables conversion #5238
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5237
Checklist
Changes proposed in this pull request:
Changing the way variables are converted to less, using
get-sass-vars
. Note that this involved forking https://github.com/niksy/node-sass-json-functions so that we can properly convert sass lists with the correct separator into the less file.Reviewers should focus on:
Screenshot
Here's the outputted less variables. The only change is that in the values of variables, references to other variables are filled in with those variables' values (and any math is computed)