[popover2] fix: declare children prop explicitly #5261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your interest in palantir/blueprint, @bradchristensen! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
adidahiya
approved these changes
Apr 21, 2022
adidahiya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5250
Checklist
Includes tests- no automated tests, but checked manually against a project of my own and confirmed it works as expected when used with React 18Update documentationChanges proposed in this pull request:
This PR defines the
childrenprop explicitly for Popover2 and Tooltip2, which is a requirement in React 18.It looks like #5258 fixed all instances of this for function components but it didn't tackle class components.
Note that I haven't checked anything beyond Popover2/Tooltip2 - there may be other affected components, but we only use a few components from Blueprint in our project at the moment.