[popover2] feat(ContextMenu2): add popoverRef to popoverProps #5280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your interest in palantir/blueprint, @dlichen! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
adidahiya
suggested changes
May 3, 2022
| @@ -206,6 +206,7 @@ export const ContextMenu2: React.FC<ContextMenu2Props> = React.forwardRef<any, C | |||
| rootBoundary="viewport" | |||
| renderTarget={renderTarget} | |||
| transitionDuration={popoverProps?.transitionDuration ?? 100} | |||
| popoverRef={popoverProps?.popoverRef} | |||
There was a problem hiding this comment.
you don't need this here, it's spread by {...popoverProps} on L187 already
| @@ -109,7 +109,7 @@ export interface ContextMenu2Props | |||
| /** | |||
| * A limited subset of props to forward along to the popover generated by this component. | |||
| */ | |||
| popoverProps?: IOverlayLifecycleProps & Pick<Popover2Props, "popoverClassName" | "transitionDuration">; | |||
| popoverProps?: IOverlayLifecycleProps & Pick<Popover2Props, "popoverClassName" | "transitionDuration" | "popoverRef">; | |||
There was a problem hiding this comment.
this line is probably too long and is failing formatting checks. run yarn format from the root of the repo.
adidahiya
approved these changes
May 3, 2022
adidahiya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes no issue
Checklist
Changes proposed in this pull request:
adding the popoverRef to the contextMenu2 component
Reviewers should focus on:
n/a
Screenshot
No visual change