-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[table] feat: new prop "enableColumnHeader" #5283
Conversation
Thanks for your interest in palantir/blueprint, @jmcglinch! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
hey @jmcglinch, thanks for the PR! This gets us most of the way there, but there's a bug in rendering because of assumptions about the minimum column header height. there are references to |
preview build: docs-app, table-dev-app |
Fixes #5200
Checklist
Changes proposed in this pull request:
Adds
enableColumnHeader
prop to table and table2 components. The column header is not rendered if false.Reviewers should focus on:
Focus on render logic relating to the column header. Also, check
SYNC_TRIGGER_PROP_KEYS
configuration.Screenshot