[table] fix: re-render immediately on changes in batched mode #5284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
preview build: table-dev-app, docs-app |
|
I confirmed that this fixes #5253 as well, you can see that in the preview build for the latest commit. I also added documentation for |
adidahiya
approved these changes
May 4, 2022
adidahiya
changed the title
adidahiya
added a commit
that referenced
this pull request
May 4, 2022
Co-authored-by: Adi Dahiya <adahiya@palantir.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5193, fixes #5253
Checklist
Changes proposed in this pull request:
When
TableBodyCellsprops change, it resets the batcher, but does so in the post-render hook, and doesn't trigger another render. This means that the batcher never gets a chance to run again.On the following time the component is rendered, it will "notice" the empty batcher and render all the cells again. This is why the update works ever second time you change something.
Reviewers should focus on:
forceUpdate()here? Or is there a better way to trigger a re-render in this case?Testing
In
table-dev-appI added the cell content to thecellRendererDependencies. You can see that if you change the cell content, the table only re-renders every 2 times if you comment out the newforceUpdate(). With theforceUpdate()it re-renders every time as expected.Screenshot
Before
After