Fix node 12 compatibility #5288
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't want to downgrade for the sake of Node 12 support; that version is already EOL. Please use |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 12 support was dropped in
eslint-plugin-jsdocversion 39 which we bumped to in this PR https://github.com/gajus/eslint-plugin-jsdoc/releases/tag/v39.0.0. Moving it back a major version to 38 fixes the compatibility issueError from running yarn locally on develop with node 12.22:
eslint-plugin-jsdoc@39.2.9: The engine "node" is incompatible with this module. Expected version "^14 || ^16 || ^17 || ^18". Got "12.22.0"Checklist
Changes proposed in this pull request:
changes
eslint-plugin-jsdocdependency version from 39.2.9 to 38.1.6 in eslint-config packageReviewers should focus on:
Screenshot