[core] fix: use solid focus outline style #5305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `auto` for the outline style allows the user agent to override the outline style, leading to different results on different systems. This changes the style to solid so that all users will see the same style.
|
@dlech which platforms are you testing on? this doesn't seem to change anything for Buttons in Firefox (AnchorButtons are good, they use the solid style):
... but I don't see any regressions with this change, so it seems like a net positive 👍🏽 |
adidahiya
approved these changes
May 26, 2022
adidahiya
changed the title
|
I don't remember if I tried Firefox (pretty sure I did though). The screenshot is from Chromium installed from the Ubuntu snap on 22.04. So apparently the white outline is the system default selected by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
autofor the outline style allows the user agent to override the outline style, leading to different results on different systems. This changes the style to solid so that all users will see the same style.Fixes #0000
Checklist
Changes proposed in this pull request:
Reviewers should focus on:
Screenshot
Before:
After: