[popover2] feat: new props matchTargetWidth, modifiersCustom #5307
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Changes proposed in this pull request:
New props for Popover2:
modifiersCustom
allows passing in custom popper.js modifiers to the popper instancemodifiers
in alphabetical sorting.matchTargetWidth
applies one of our own custom popper.js modifiers to make the popover content match the width of the target (reference) elementmatchTargetWidth
in a better way in the upcoming Select2 component in [select] feat: new Select2 component uses Popover2 #5306matchTargetWidth
in Select because that component uses Popover, not Popover2Reviewers should focus on:
Example in docs works correctly
Screenshot