Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[popover2] feat: new props matchTargetWidth, modifiersCustom #5307

Merged
merged 2 commits into from
May 16, 2022

Conversation

adidahiya
Copy link
Contributor

@adidahiya adidahiya commented May 16, 2022

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

New props for Popover2:

  • modifiersCustom allows passing in custom popper.js modifiers to the popper instance
    • note that this name was chosen so that it can appear right next to modifiers in alphabetical sorting.
  • matchTargetWidth applies one of our own custom popper.js modifiers to make the popover content match the width of the target (reference) element

Reviewers should focus on:

Example in docs works correctly

Screenshot

image

image

@blueprint-bot
Copy link

[popover2] feat: new props matchTargetWidth, modifiersCustom

Previews: documentation | landing | table | demo

@blueprint-bot
Copy link

Add unit test

Previews: documentation | landing | table | demo

@adidahiya adidahiya merged commit a6453da into develop May 16, 2022
@adidahiya adidahiya deleted the ad/popover2-custom-modifiers branch May 16, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants