Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] feat(Dialog): add containerRef prop #5314

Merged
merged 9 commits into from
May 27, 2022
Merged

[core] feat(Dialog): add containerRef prop #5314

merged 9 commits into from
May 27, 2022

Commits on May 23, 2022

  1. added a ref prop to Dialog

    @dlichen
    dlichen committed May 23, 2022
    Configuration menu
    Copy the full SHA
    9593fb4 View commit details
    Browse the repository at this point in the history

  2. fixed comment

    @dlichen
    dlichen committed May 23, 2022
    Configuration menu
    Copy the full SHA
    eb5cf57 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2022

  1. Update packages/core/src/components/dialog/dialog.tsx 

    Co-authored-by: Adi Dahiya <adi.dahiya14@gmail.com>
    @dlichen @adidahiya
    dlichen and adidahiya authored May 24, 2022
    Configuration menu
    Copy the full SHA
    7ecc68e View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from palantir/develop 

    Merging in changes to dlichen/blueprint
    @dlichen
    dlichen authored May 24, 2022
    Configuration menu
    Copy the full SHA
    ea49086 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into dlichen/addRefToDialog

    @dlichen
    dlichen committed May 24, 2022
    Configuration menu
    Copy the full SHA
    99c2498 View commit details
    Browse the repository at this point in the history

  4. fixing something

    @dlichen
    dlichen committed May 24, 2022
    Configuration menu
    Copy the full SHA
    cb17689 View commit details
    Browse the repository at this point in the history

  5. just pushing the test for the pr's sake... cannot figure out yarn tes… 

    …t locally currently
    @dlichen
    dlichen committed May 24, 2022
    Configuration menu
    Copy the full SHA
    897e71b View commit details
    Browse the repository at this point in the history

Commits on May 25, 2022

  1. added timeout for lifecycle

    @dlichen
    dlichen committed May 25, 2022
    Configuration menu
    Copy the full SHA
    fb004b1 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2022

  1. Fix dialog tests

    @adidahiya
    adidahiya committed May 27, 2022
    Configuration menu
    Copy the full SHA
    9fd5ae0 View commit details
    Browse the repository at this point in the history