Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] feat(Spinner): add more a11y markup, support HTML attrs #5321

Merged
merged 4 commits into from
May 25, 2022

Conversation

bvandercar-vt
Copy link
Contributor

Fixes #5317

Checklist

  • Includes tests
  • [N/A] Update documentation

Changes proposed in this pull request:

Allow custom html props to be passed to Spinner

@palantirtech
Copy link
Member

Thanks for your interest in palantir/blueprint, @bvandercar-vt! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@bvandercar-vt
Copy link
Contributor Author

I am on Windows 10 and am getting errors when running yarn verify/yarn compile, and cannot run yarn testeither-- can one of the Devs please check out this branch and run the test I've written plus whatever else needs to be done?

@adidahiya adidahiya changed the title Bv/spinner html props (#5317) [core] feat(Spinner): support HTML attributes (#5317) May 25, 2022
@adidahiya adidahiya self-assigned this May 25, 2022
@adidahiya
Copy link
Contributor

@bvandercar-vt compilation and tests look good, I got them to pass locally, and they pass in CI.

I pushed an additional commit to add more recommended aria- attributes according to the MDN documentation for role="progressbar".

@adidahiya adidahiya changed the title [core] feat(Spinner): support HTML attributes (#5317) [core] feat(Spinner): add more a11y attrs, support arbitrary attrs (#5317) May 25, 2022
@adidahiya adidahiya changed the title [core] feat(Spinner): add more a11y attrs, support arbitrary attrs (#5317) [core] feat(Spinner): add more a11y markup, support HTML attrs (#5317) May 25, 2022
@adidahiya adidahiya changed the title [core] feat(Spinner): add more a11y markup, support HTML attrs (#5317) [core] feat(Spinner): add more a11y markup, support HTML attrs May 25, 2022
@bvandercar-vt
Copy link
Contributor Author

@bvandercar-vt compilation and tests look good, I got them to pass locally, and they pass in CI.

I pushed an additional commit to add more recommended aria- attributes according to the MDN documentation for role="progressbar".

Awesome, thanks for your help!

@adidahiya
Copy link
Contributor

docs preview build here

@adidahiya adidahiya merged commit cc2b8ee into palantir:develop May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spinner item does not take other props
3 participants