-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] feat(Spinner): add more a11y markup, support HTML attrs #5321
[core] feat(Spinner): add more a11y markup, support HTML attrs #5321
Conversation
Thanks for your interest in palantir/blueprint, @bvandercar-vt! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
I am on Windows 10 and am getting errors when running |
@bvandercar-vt compilation and tests look good, I got them to pass locally, and they pass in CI. I pushed an additional commit to add more recommended |
Awesome, thanks for your help! |
Fixes #5317
Checklist
Changes proposed in this pull request:
Allow custom html props to be passed to
Spinner