Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[select] feat: new MultiSelect2 component uses Popover2 #5329

Merged
merged 4 commits into from
May 26, 2022

Conversation

adidahiya
Copy link
Contributor

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Create a new MultiSelect2 component which uses Popover2 instead of Popover under the hood.

Reviewers should focus on:

Note the changes required to manually reposition the popover after adding or removing items from the selection. This was apparently not required with popper.js v1, but seems to be required with v2 due to its performance optimizations. See the docs about this.

Screenshot

image

2022-05-26 17 34 16

@blueprint-bot
Copy link

reposition popover on selected items changes

Previews: documentation | landing | table | demo

@adidahiya adidahiya merged commit 740a0b6 into develop May 26, 2022
@adidahiya adidahiya deleted the ad/multiselect2 branch May 26, 2022 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants