Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[select] chore: clean up code+docs, deprecate v1 components #5330

Merged
merged 8 commits into from
May 27, 2022
Merged

[select] chore: clean up code+docs, deprecate v1 components #5330

merged 8 commits into from
May 27, 2022

Conversation

adidahiya
Copy link
Contributor

Changes proposed in this pull request:

  • Move select/suggest/multi-select components into respective folders, for more predictable repo layout & discoverability
  • Tidy up select package component documentation, with better formatting and docs links
  • Actually deprecate Select, Suggest, and MultiSelect in the public API via JSDoc /** @deprecated **/

Reviewers should focus on:

No regressions

Screenshot

N/A

@adidahiya adidahiya changed the title [select] chore: move src files into component folders [select] chore: clean up code+docs, deprecate v1 components May 27, 2022
@blueprint-bot
Copy link

fix sass imports

Previews: documentation | landing | table | demo

@adidahiya adidahiya merged commit 22d2e04 into develop May 27, 2022
@adidahiya adidahiya deleted the ad/select-cleanup branch May 27, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adidahiya @blueprint-bot