Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[select] fix(MultiSelect2): popoverProps placement prop warning #5340

Merged
merged 1 commit into from
Jun 1, 2022
Merged

[select] fix(MultiSelect2): popoverProps placement prop warning #5340

merged 1 commit into from
Jun 1, 2022

Conversation

bvandercar-vt
Copy link
Contributor

Fixes #0000

Checklist

  • [N/A] Includes tests
  • [[N/A] Update documentation

Changes proposed in this pull request:

Before this change, would get the warning <Popover2> supports either placement or position prop, not both. if specifying a position in the popoverProps of a MultiSelect2, due to the default placement being passed.

@adidahiya adidahiya changed the title fix: placement prop warning when specifying position prop on MultiSelect2 [select] fix(MultiSelect2): popoverProps placement/position prop warning Jun 1, 2022
@adidahiya adidahiya changed the title [select] fix(MultiSelect2): popoverProps placement/position prop warning [select] fix(MultiSelect2): popoverProps placement prop warning Jun 1, 2022
@adidahiya adidahiya merged commit c5a9c46 into palantir:develop Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adidahiya adidahiya adidahiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bvandercar-vt @adidahiya