Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[select] feat(Select2, MultiSelect2): popoverContentProps #5346

Merged
merged 2 commits into from
Jun 2, 2022
Merged

[select] feat(Select2, MultiSelect2): popoverContentProps #5346

merged 2 commits into from
Jun 2, 2022

Conversation

bvandercar-vt
Copy link
Contributor

Fixes #0000

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

allow popoverContentProps to be passed to MultiSelect2 and Select2. Allows user to apply props such as aria-label or data-testid to the popover that is created by these elements.

@bvandercar-vt bvandercar-vt changed the title Bv/selec2/multiselect2 popover content props Bv/ select2/multiselect2 popover content props Jun 2, 2022
adidahiya
adidahiya approved these changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, clean 👍🏽

@adidahiya adidahiya changed the title Bv/ select2/multiselect2 popover content props [select] feat(Select2, MultiSelect2): new prop 'popoverContentProps' Jun 2, 2022
@adidahiya adidahiya changed the title [select] feat(Select2, MultiSelect2): new prop 'popoverContentProps' [select] feat(Select2, MultiSelect2): popoverContentProps Jun 2, 2022
@adidahiya adidahiya merged commit 2f76b9f into palantir:develop Jun 2, 2022
@adidahiya
Copy link
Contributor

I'm adding the same for Suggest2 here: #5347

@adidahiya adidahiya mentioned this pull request Jun 2, 2022
Merged
@bvandercar-vt
Copy link
Contributor Author

@adidahiya why was PopoverContentProps removed from the props interfaces after this was merged? We need to re-add those

@adidahiya
Copy link
Contributor

@bvandercar-vt it's inherited from here in the shared interface:

blueprint/packages/select/src/common/selectPopoverProps.ts

Line 25 in 7ea317e

popoverContentProps?: React.HTMLAttributes<HTMLDivElement>;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adidahiya adidahiya adidahiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bvandercar-vt @adidahiya