[select] fix: ARIA listbox popup type and combobox list role

[bvandercar-vt]

Fixes #0000

Checklist

• Includes tests
• Update documentation

Changes proposed in this pull request:

Apply role="listbox" for the Menu created by QueryList-- Menu has role="menu" by default, and listbox is more applicable here. Also apply role="combobox" to the item that creates the listbox popover

Trying to model after https://www.digitala11y.com/combobox-role/ for Select2 and MultiSelect2, https://www.w3.org/TR/2021/NOTE-wai-aria-practices-1.2-20211129/examples/combobox/combobox-autocomplete-list.html for Suggest2.

with menuProps, user can pass a custom id (or other props) to the Menu created within the Select/Multiselect popover.

[adidahiya]

can you please add these attributes for Suggest2 as well? thanks

[bvandercar-vt]

can you please add these attributes for Suggest2 as well? thanks

Updated Suggest2 to match the suggest combobox example here https://www.w3.org/TR/2021/NOTE-wai-aria-practices-1.2-20211129/examples/combobox/combobox-autocomplete-list.html

[adidahiya]

Almost there... thanks for iterating with me on this.

I don't like to use the term "wrapper" in the API; it's a little too ambiguous. And besides we had a "wrapper" element in Popover v1 which we've gotten rid of in Popover2, so I don't want to re-introduce that term.

[adidahiya]

Quick note for using Github's suggestions feature - it's possible to batch suggestions into a single commit, see the docs here. Not a big deal or important for my review, just something for your convenience.

[bvandercar-vt]

Quick note for using Github's suggestions feature - it's possible to batch suggestions into a single commit, see the docs here. Not a big deal or important for my review, just something for your convenience.

Thanks, great tip!! I also re-ordered the props in alphabetical order given the change

[adidahiya]

Latest code looks great.

with menuProps, user can pass a custom id (or other props) to the Menu created within the Select/Multiselect popover.

do you still need this feature now that we auto-generate the ID?

[bvandercar-vt]

Latest code looks great.

with menuProps, user can pass a custom id (or other props) to the Menu created within the Select/Multiselect popover.

do you still need this feature now that we auto-generate the ID?

yes we need it so that we can pass the id prop to the Menu created in the queryList

[adidahiya]

cool, thanks for removing that extra addition to the public API. I am open to adding it in the future if necessary, but I prefer to be conservative about adding to the API for now.