-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[select] fix: ARIA listbox popup type and combobox list role #5348
[select] fix: ARIA listbox popup type and combobox list role #5348
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please add these attributes for Suggest2 as well? thanks
Updated Suggest2 to match the suggest combobox example here https://www.w3.org/TR/2021/NOTE-wai-aria-practices-1.2-20211129/examples/combobox/combobox-autocomplete-list.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there... thanks for iterating with me on this.
I don't like to use the term "wrapper" in the API; it's a little too ambiguous. And besides we had a "wrapper" element in Popover v1 which we've gotten rid of in Popover2, so I don't want to re-introduce that term.
Co-authored-by: Adi Dahiya <adi.dahiya14@gmail.com>
Co-authored-by: Adi Dahiya <adi.dahiya14@gmail.com>
Co-authored-by: Adi Dahiya <adi.dahiya14@gmail.com>
Co-authored-by: Adi Dahiya <adi.dahiya14@gmail.com>
Co-authored-by: Adi Dahiya <adi.dahiya14@gmail.com>
Co-authored-by: Adi Dahiya <adi.dahiya14@gmail.com>
Co-authored-by: Adi Dahiya <adi.dahiya14@gmail.com>
Quick note for using Github's suggestions feature - it's possible to batch suggestions into a single commit, see the docs here. Not a big deal or important for my review, just something for your convenience. |
Thanks, great tip!! I also re-ordered the props in alphabetical order given the change |
Latest code looks great.
do you still need this feature now that we auto-generate the ID? |
yes we need it so that we can pass the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, thanks for removing that extra addition to the public API. I am open to adding it in the future if necessary, but I prefer to be conservative about adding to the API for now.
Fixes #0000
Checklist
Changes proposed in this pull request:
Apply
role="listbox"
for theMenu
created byQueryList
--Menu
hasrole="menu"
by default, andlistbox
is more applicable here. Also applyrole="combobox"
to the item that creates thelistbox
popoverTrying to model after https://www.digitala11y.com/combobox-role/ for Select2 and MultiSelect2, https://www.w3.org/TR/2021/NOTE-wai-aria-practices-1.2-20211129/examples/combobox/combobox-autocomplete-list.html for Suggest2.
with
menuProps
, user can pass a customid
(or other props) to theMenu
created within the Select/Multiselect popover.