Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] fix(ResizeSensor): compatibility with React 18 #5362

Merged
merged 1 commit into from
Jun 8, 2022
Merged

[core] fix(ResizeSensor): compatibility with React 18 #5362

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/core/src/components/resize-sensor/resizeSensor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export class ResizeSensor extends AbstractPureComponent2<ResizeSensorProps> {

private observer = new ResizeObserver(entries => this.props.onResize?.(entries));

public render() {
public render(): React.ReactNode {
// pass-through render of single child
return React.Children.only(this.props.children);
}
Expand All @@ -77,6 +77,7 @@ export class ResizeSensor extends AbstractPureComponent2<ResizeSensorProps> {

public componentWillUnmount() {
this.observer.disconnect();
this.element = null;
}

/**
Expand Down