-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[popover2] feat(ContextMenu2): support popoverProps.rootBoundary #5423
[popover2] feat(ContextMenu2): support popoverProps.rootBoundary #5423
Conversation
Thanks for your interest in palantir/blueprint, @GalvinGao! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
@GalvinGao I edited your change to have a more minimal code diff. I think we should test this change in the docs app or a unit test before merging. You could add a ContextMenu2 to the Drawer example in the docs-app for testing: https://github.com/palantir/blueprint/blob/develop/packages/docs-app/src/examples/core-examples/drawerExample.tsx You may need to set |
@GalvinGao are you still interested in this PR? Can you add a unit test? |
Just got time. Gonna add it today or tomorrow. |
Added docs & unit tests. Ready for review ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes #5411
Checklist
Changes proposed in this pull request:
rootBoundary
value inContextMenu2
component.Reviewers should focus on:
Screenshot
N/A: I'm unsure exactly how to test such change. I've tried to just add a Example component in the docs by following what other documents appear to do, but I found that the problem mentioned in #5411 is not reproducible within the docs-app for unknown reasons. Therefore I'm unsure if adding the
rootBoundary
props to theContextMenu2
will actually open the door for developers to mitigate this issue. Any help would be appreciated.